Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add cat indices API #4465

Merged
merged 3 commits into from
Jan 30, 2024
Merged

add cat indices API #4465

merged 3 commits into from
Jan 30, 2024

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Jan 26, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@PSeitz PSeitz force-pushed the cat_indices branch 4 times, most recently from d475f9e to cbd28d9 Compare January 27, 2024 07:20
@PSeitz PSeitz requested a review from fmassot January 27, 2024 07:22
format!("Parameter {:?} is not supported.", field),
)
};
if self.bytes.is_some() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice checks

method: [GET]
engines:
- quickwit
endpoint: "_cat/indices/gharchive?format=json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with a glob pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I added a test

@PSeitz PSeitz merged commit 99a92dd into main Jan 30, 2024
4 checks passed
@PSeitz PSeitz deleted the cat_indices branch January 30, 2024 04:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants