Fix delete task not respecting default fields #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
commented
Feb 20, 2025
| @@ -45,8 +45,9 @@ pub struct DeleteQueryRequest { | |||
| /// Query text. The query language is that of tantivy. | |||
| pub query: String, | |||
| // Fields to search on | |||
| #[serde(rename(deserialize = "search_field"))] | |||
There was a problem hiding this comment.
this is necessary to be consistent with the docs and the search API
quickwit/quickwit/quickwit-serve/src/search_api/rest_handler.rs
Lines 190 to 197 in ce3ae77
fulmicoton
approved these changes
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This seems to have been broken in #3148
According to the docs, delete tasks should support default fields
quickwit/docs/reference/rest-api.md
Line 759 in 722cb87
How was this PR tested?
Unit tests.