feat: warn user and halt install if cgroup2fs is missing #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-fs
approved these changes
Sep 5, 2024
Relates to JIRA: DISCOVERY-612
infinitewarp
force-pushed
the
require-cgroup2fs
branch
from
1d7903e to
df4ab10
Compare
|
do we need to do this check |
The way I looked at it is it doesn't hurt to check on all other distros as well. I also ran the updated installer on a stock RHEL9 VM, and this conditional was skipped as expected, since cgroup2fs was already present, but maybe it's possible for someone to disable cgroup2fs on RHEL9+? 🤷 |
abellotti
approved these changes
Sep 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to JIRA: DISCOVERY-612