-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(rpm): Adding support for building a discovery-installer rpm #7
Conversation
3550fed
to
5dc6db8
Compare
Un-published Install time overrides can be provided with an optional configuration directory that the install will merge values when copying the container and env files. The provided files will only include the values to overlay. i.e.
The optional directory will contain any of the files we need the installer to overlay (with just the data that needs changing), i.e:
For example, specifying alternate images for versions to test or architecture, the override configuration directory would include: discovery-server.container
discovery-app.container
|
07e7af8
to
f5d8183
Compare
- Add spec and supporting scripts to building a discovery-installer rpm - Version as 1.7 for installer - Pull 1.7 images (should be tagged with latest patch version)
- Preferring to use /usr/share/discovery-installer instead of /etc/discovery-installer as the RPM package installation directory as we're not a system/OS service.
- Added server password restriction checks. - password must be at least 10 characters long - password must include at least one letter a-z A-Z - password cannot be dscpassw0rd or qpcpassw0rd
- Supporting packit for upstream copr builds
…tall - installer should check the existence of the server password and application secret only when running the install.
f5d8183
to
dd6c320
Compare
- Updated the README.md and NOTES.md files to reflect the RPM based usage of the discovery-installer and managing services via systemctl.
- Removed the Environment= from the Ansible env file (those are unit file signatures) - Removed the trailing lines from the container unit files
630e9d5
to
618fc63
Compare
- Support -v or --verbose for debugging the overrides performed - Support *.env file overrides from the --override-conf-dir directory. - Support *.container file overrides from the --override-conf-dir directory.
618fc63
to
da024ed
Compare
- Improved some variable names uses in the method. - Missing copy of the container files in case there were no overrides.
- Keeping the installer's responsibility with just Discovery. opening up firewall port and such will be documented outside the scope of the installer.
- Now that we build x.y tags with releases (i.e. 1.8.1 and 1.8) updating the config container files to pull the x.y tag image so the 1.8 RPM always pulls the latest discovery 1.8 images.
- For consistency with upstream qpc and also, CentOS Stream 8 image is no longer available for packit.
…n too. - Updated the create-app-secret script to not default to development as it can be used for production too. Script now checks for empty inputs and prompts the user a second time for verification before creating the podman secret. - Updated the NOTES.md file to include the Quadlet References we had in the old README.md
Draft
NOTE: