Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(celery-worker): Should mount the /sshkeys just like the server #9

Merged
merged 1 commit into from
May 14, 2024

Conversation

abellotti
Copy link
Contributor

  • Celery worker should be mounting the /sshkeys just like the server as tasks would require that if configured to authenticate as such.

- Celery worker should be mounting the /sshkeys just like the server
  as tasks would require that if configured to authenticate as such.
Copy link
Contributor

@mirekdlugosz mirekdlugosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Obviously not blocking, but I wonder if these units should be generated from single source? Would also make it easier to deploy multiple Celery workers. The only difference between API server and Celery worker is, and should be, the entrypoint.

systemd has the concept of template units (Fedora Magazine). I don't know if you can merge them with quadlets, but then you could have discovery@api, discovery@worker-1, discovery@worker-2 etc.

@abellotti
Copy link
Contributor Author

abellotti commented May 14, 2024

The original prototype with Quadlet had templates implemented for celery-worker for scalability, with script to scale the workers, discovery-celery-worker@1, discovery-celery-worker@2, etc. However, this was overkill as we're running on a single system (vs. OCP pods and such). we decided to use the Celery process auto-scaler and a single pod.

See commit 0642de4 for the switch.

@abellotti abellotti merged commit 900f8f7 into quipucords:main May 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants