Skip to content

[Issue #440] ignore errors in rmtree #753

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

ulisesojeda
Copy link
Contributor

@ulisesojeda ulisesojeda commented Feb 14, 2025

@daniil-quix
Copy link
Collaborator

Hi @ulisesojeda , thanks for lending a hand with it!

Can you please add a test covering your update as well?
Cheers!

@ulisesojeda
Copy link
Contributor Author

Hi @ulisesojeda , thanks for lending a hand with it!

Can you please add a test covering your update as well? Cheers!

Hi @daniil-quix. Added

@daniil-quix
Copy link
Collaborator

daniil-quix commented Feb 17, 2025

Thanks @ulisesojeda.
Can you please also re-format your changes with ruff?
There's a pre-commit hook to validate the formatting as well (see our https://github.com/quixio/quix-streams/blob/main/CONTRIBUTING.md for how to set this up)

The CI check fails because of that - https://github.com/quixio/quix-streams/actions/runs/13358391484/job/37331218829?pr=753

@ulisesojeda
Copy link
Contributor Author

Thanks @ulisesojeda. Can you please also re-format your changes with ruff? There's a pre-commit hook to validate the formatting as well (see our https://github.com/quixio/quix-streams/blob/main/CONTRIBUTING.md for how to set this up)

The CI check fails because of that - https://github.com/quixio/quix-streams/actions/runs/13358391484/job/37331218829?pr=753

Ready. Thanks

@daniil-quix daniil-quix merged commit dc60d11 into quixio:main Feb 20, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants