Detach sinks and backpressure from topic-partitions #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinks may fail more often because they are external. Failing early allows to skip producing changelogs and restart faster.
- Sink.flush() now flushes all the accumulated batches - Backpressure pauses the whole assignment instead of a single partition
gwaramadze
reviewed
Mar 13, 2025
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
- Add helper to get non-changelog TPs - Reset PausingManager on init
gwaramadze
approved these changes
Mar 13, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, Sinks are tightly coupled with topic partitions, which doesn't work well with the upcoming joins and merges.
This PR removes the dependency on TPs from certain Sinks methods.
BatchingSinkclasses keep batching data per TP to reduce the amount of the changed code, butBatchingSink.flush()will flush all the batches.Main changes
This is done to minimize potential over-production in case of Sink's failure.
Sink.flush()- it is now expected to flush all the accumulated data for all TPs.SinkBackpressureErrornow pauses the whole assignment instead of certain partitions only.