Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Show diff only when it helps #335

Closed
jzaefferer opened this issue Oct 22, 2012 · 1 comment
Closed

Show diff only when it helps #335

jzaefferer opened this issue Oct 22, 2012 · 1 comment
Labels
Component: Diff

Comments

@jzaefferer
Copy link
Member

If the length of the diff is just the length of expected.length + actual.length, its likely to be useless. Its only useful if it can reduce the input.
@jzaefferer
Copy link
Member Author

Not as easy as it seems. Current diffs have irregular whitespace and since they contain markup for the red/green highlighting, their length can't be compared to the input without getting rid of the markup first. Should try #364 before spending more time on this.

@jzaefferer jzaefferer mentioned this issue Jan 31, 2014
Closed
@jzaefferer jzaefferer mentioned this issue Feb 13, 2014
Closed
shivamdixit added a commit to shivamdixit/qunit that referenced this issue Mar 17, 2015
@shivamdixit
HTML Reporter: Show diff only when it helps
1772e3e 
Don't show diff if expected and actual values are completely different
and there is nothing in common

Fixes qunitjs#335
@shivamdixit shivamdixit mentioned this issue Mar 17, 2015
Closed
leobalter pushed a commit that referenced this issue Mar 26, 2015
@shivamdixit @leobalter
HTML Reporter: Make it more obvious why diff is suppressed.
ecc33ac 
Ref #335
Ref #786
Closes #795
leobalter pushed a commit to leobalter/qunit that referenced this issue Mar 27, 2015
@shivamdixit @leobalter
HTML Reporter: Show diff only when it helps
1cefa7f 
Don't show diff if expected and actual values are completely different
and there is nothing in common

Fixes qunitjs#335
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Component: Diff
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HTML Reporter: Show diff only when it helps shivamdixit/qunit
1 participant
@jzaefferer