Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QUnit - Better diff output #774

Closed
gauravmittal1995 opened this issue Mar 10, 2015 · 9 comments
Closed

QUnit - Better diff output #774

gauravmittal1995 opened this issue Mar 10, 2015 · 9 comments

Comments

@gauravmittal1995
Copy link
Contributor

For the GSoC project "QUnit - Better diff output", what are the requirements and details??

Any other issues apart the ones mentioned in #364 ???

@leobalter @jzaefferer Please advice.

@jzaefferer
Copy link
Member

#364 is our meta ticket for the topic, that's definitely the best reference.

One thing not mentioned there, that came up with the recent PRs: We should have better tests for diffs. The ones you screenshotted in #764 are a good starting point. A visual test page (failing tests?) would be good for manual, visual verification. Automated tests that somehow prevent regressions would also help, maybe by checking the length of a diff, ensuring that changes to the diff don't make it worse (if longer always means worse).

Another idea: Do some research across JS testing frameworks. See what others to about diffing, if at all. See if we should (eventually) extract our diff module into a standalone module, that other frameworks could use. Should find at least two frameworks actually interested in that before making any changes on our end.

That's two additional tasks I can think of right now. There's probably more.

I'm assuming you're asking this to write your proposal. If you need a reference, this one (for jQuery UI) seems pretty decent to me.

@gauravmittal1995
Copy link
Contributor Author

@jzaefferer Do i make a proposal and put it on gist as well??

@jzaefferer
Copy link
Member

Sure, that way we can review it before the official submission process starts. Doesn't have to be a gist, anything you can share with us should work.

PS: One question mark is enough ;-)

@gauravmittal1995
Copy link
Contributor Author

@jzaefferer Thanks :-D

@gauravmittal1995
Copy link
Contributor Author

@jzaefferer @leobalter Hey, I have a doubt in the proposal. How do i make my timeline. I dont know how much time each task could take. How do i decide that?

@shivamdixit
Copy link
Contributor

@jzaefferer I've two questions in my mind:

  1. For the GSOC project do we need to improve the current diff algorithm of @jeresig or as the other tickets suggest that we can use some already existing libraries for diff?
  2. If we are using already existing library I'm not sure why we should extract that module into standalone module (It's already there)?

Thanks.

@jzaefferer
Copy link
Member

@gauravmittal1995 take the time since you started your first PR to landing it (you may need to extrapolate that, since its still open). Then multiply that by two and you have a rough estimate. Or just guess. Or assume one week per task. Don't worry too much about it, time estimates are never something to stick strict deadlines to.

@shivamdixit check out #772, that should answer both your questions.

@gauravmittal1995
Copy link
Contributor Author

@jzaefferer Thanks

@jzaefferer
Copy link
Member

Closing this since there's nothing to discuss here and the underlying diff-related issues are enough.

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

No branches or pull requests

3 participants