HTML Reporter: Fixed the confusing Line Breaks in Diffs

[gauravmittal1995]

Regarding #348
In the Below picture:
1st assert has same keys but different values,
2nd assert is for two strings,
3rd assert has different keys but similar values.

[gauravmittal1995]

@leobalter @jzaefferer Please Review

[jzaefferer]

Can you provide a screenshot of those same diffs without the changes of this PR applied?

[jzaefferer]

Also #348 had an example where an object was replaced by an array. Could you cover that as well?

[gauravmittal1995]

@jzaefferer for the object replaced by array:

[gauravmittal1995]

Now for without the change (i.e originally):

[gauravmittal1995]

@jzaefferer Hey, I also tried another way and got the following diff:

Please Let me know which one according to you is better.

[jzaefferer]

Both approaches are definitely an improvement over the current implementation. The "another way" looks even better to me. We may need more tests to avoid regressions though.

@leobalter what do you think?

[gauravmittal1995]

@jzaefferer the another way uses google's diff-patch-match library.

[jzaefferer]

Ah, good to know. Could you create a separate PR for that?

[leobalter]

I liked these changes, but I would like to see this other PR as it looks better.

[gauravmittal1995]

@jzaefferer @leobalter Creating the new PR. Its taking time because have to refactor as it doesnt use cameCase and vars are scattered throughout the function. Will send it soon

[leobalter]

As it is an external library, it would be good to ignore it on jshint and jscs checks. Also, getting the code from a npm dependency would be nice.

[gauravmittal1995]

@leobalter @jzaefferer PR opened #772

[gauravmittal1995]

@jzaefferer I think its safe to close this PR as we r mostly gonna stick with #772 ??

[leobalter]

Yes, @gauravmittal1995, thanks!