Core: Add type checking for assert.async #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Thanks for the patch @zixinyin!
Would you mind adding a basic test for it as well?
For the core API (platform-agnostic) our tests are under https://github.com/qunitjs/qunit/tree/main/test/main/
You're welcome! I added the test as a new commit. I found the invalid link for CLA here |
|
Hello @Krinkle I have submitted the test. Should I leave this PR as it is? Not sure the following steps for merging. |
Krinkle
approved these changes
Aug 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type checking for assert.async, so for an invalid input like string, the page would not hang indefinitely.
Fixes #1721