fix face-centered BCs for refined levels #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
for more information, see https://pre-commit.ci
|
Azure Pipelines successfully started running 5 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 5 pipeline(s). |
…quokka into BenWibking/fix-facevar-bcs
markkrumholz
approved these changes
Mar 29, 2024
markkrumholz
approved these changes
Mar 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Face-centered boundary conditions weren't using the correct physical boundary functor for refined levels.
Since we currently don't evolve any face-centered vars with AMR, this bug should not have affected anyone.
Related issues
N/A
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.