Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changed parameters in pulse_grey test to reduce runtime #625

Merged
merged 1 commit into from
May 2, 2024

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented May 2, 2024

Description

Address issue #624 . I reduced max_time of the test_radhydro_pulse_grey test by ~5. Now the runtime of this test on my Mac Studio reduced from 28 s to 6 s.

Related issues

Fixes #624.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@BenWibking BenWibking added this pull request to the merge queue May 2, 2024
Merged via the queue into development with commit f7d0e90 May 2, 2024
21 checks passed
@chongchonghe chongchonghe deleted the chongchong/reduce-pulse-grey-runtime branch May 3, 2024 00:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadhydroPulseGrey causes stochastic test timeouts and merge failure
2 participants