Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CUDA 12.6 hotfix #708

Merged
merged 1 commit into from
Aug 8, 2024
Merged

CUDA 12.6 hotfix #708

merged 1 commit into from
Aug 8, 2024

Conversation

BenWibking
Copy link
Collaborator

Description

Update AMReX to fix a bug so we can compile with CUDA 12.6.

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 7, 2024
@BenWibking
Copy link
Collaborator Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BenWibking BenWibking enabled auto-merge August 7, 2024 17:01
@BenWibking
Copy link
Collaborator Author

For historical reference, here are the timings for all of the test problems with a sufficiently-cooled GPU card:

2024-08-07T16:28:41.6280837Z [command]/usr/bin/cmake -E chdir . ctest -E MatterEnergyExchange* -T Test --output-on-failure
2024-08-07T16:28:41.6586224Z    Site: avatargpu.anu.edu.au
2024-08-07T16:28:41.6586590Z    Build name: Linux-c++
2024-08-07T16:28:41.6613959Z Create new tag: 20240807-1628 - Experimental
2024-08-07T16:28:41.6616204Z Test project /tmp/bwibking/_work/1/s/build
2024-08-07T16:28:41.6656358Z       Start  1: ScalarAdvection
2024-08-07T16:28:48.6814897Z  1/43 Test  #1: ScalarAdvection ...................   Passed    7.02 sec
2024-08-07T16:28:48.6819551Z       Start  2: Advection2D
2024-08-07T16:29:31.8578873Z  2/43 Test  #2: Advection2D .......................   Passed   43.18 sec
2024-08-07T16:29:31.8581090Z       Start  3: ScalarAdvectionSemiEllipse
2024-08-07T16:29:38.5099919Z  3/43 Test  #3: ScalarAdvectionSemiEllipse ........   Passed    6.65 sec
2024-08-07T16:29:38.5100774Z       Start  4: HydroBlast3D
2024-08-07T16:35:48.8144392Z  4/43 Test  #4: HydroBlast3D ......................   Passed  370.30 sec
2024-08-07T16:35:48.8145310Z       Start  5: HydroContact
2024-08-07T16:35:51.2052741Z  5/43 Test  #5: HydroContact ......................   Passed    2.39 sec
2024-08-07T16:35:51.2054398Z       Start  6: HydroLeblanc
2024-08-07T16:36:51.0454220Z  6/43 Test  #6: HydroLeblanc ......................   Passed   59.84 sec
2024-08-07T16:36:51.0455320Z       Start  7: HydroShocktube
2024-08-07T16:37:33.1344310Z  7/43 Test  #7: HydroShocktube ....................   Passed   42.09 sec
2024-08-07T16:37:33.1346322Z       Start  8: HydroShocktubeCMA
2024-08-07T16:44:09.3111189Z  8/43 Test  #8: HydroShocktubeCMA .................   Passed  396.18 sec
2024-08-07T16:44:09.3116339Z       Start  9: ShuOsher
2024-08-07T16:44:45.7487306Z  9/43 Test  #9: ShuOsher ..........................   Passed   36.44 sec
2024-08-07T16:44:45.7488788Z       Start 10: HydroSlowMovingShock
2024-08-07T16:44:56.3391422Z 10/43 Test #10: HydroSlowMovingShock ..............   Passed   10.59 sec
2024-08-07T16:44:56.3392040Z       Start 11: HydroVacuum
2024-08-07T16:44:58.5013994Z 11/43 Test #11: HydroVacuum .......................   Passed    2.16 sec
2024-08-07T16:44:58.5014638Z       Start 12: HydroWave
2024-08-07T16:45:01.8013449Z 12/43 Test #12: HydroWave .........................   Passed    3.30 sec
2024-08-07T16:45:01.8014126Z       Start 13: HydroQuirk
2024-08-07T16:45:05.2429126Z 13/43 Test #13: HydroQuirk ........................   Passed    3.44 sec
2024-08-07T16:45:05.2429820Z       Start 14: HydroHighMach
2024-08-07T16:45:07.5186144Z 14/43 Test #14: HydroHighMach .....................   Passed    2.28 sec
2024-08-07T16:45:07.5186721Z       Start 15: RadForce
2024-08-07T16:45:48.8181287Z 15/43 Test #15: RadForce ..........................   Passed   41.30 sec
2024-08-07T16:45:48.8183398Z       Start 16: MarshakWave
2024-08-07T16:45:56.0617585Z 16/43 Test #16: MarshakWave .......................   Passed    7.24 sec
2024-08-07T16:45:56.0618257Z       Start 17: MarshakWaveCGS
2024-08-07T16:45:58.9246489Z 17/43 Test #17: MarshakWaveCGS ....................   Passed    2.86 sec
2024-08-07T16:45:58.9247104Z       Start 18: MarshakWaveAsymptoticDiffusion
2024-08-07T16:46:02.0117180Z 18/43 Test #18: MarshakWaveAsymptoticDiffusion ....   Passed    3.09 sec
2024-08-07T16:46:02.0118124Z       Start 19: MarshakWaveAsymptoticCorr
2024-08-07T16:46:05.2338752Z 19/43 Test #19: MarshakWaveAsymptoticCorr .........   Passed    3.22 sec
2024-08-07T16:46:05.2339652Z       Start 20: MarshakWaveVaytet
2024-08-07T16:53:01.7953467Z 20/43 Test #20: MarshakWaveVaytet .................   Passed  416.56 sec
2024-08-07T16:53:01.7955272Z       Start 21: RadiationPulse
2024-08-07T16:53:44.8240029Z 21/43 Test #21: RadiationPulse ....................   Passed   43.03 sec
2024-08-07T16:53:44.8242655Z       Start 22: RadiationStreaming
2024-08-07T16:53:48.7411173Z 22/43 Test #22: RadiationStreaming ................   Passed    3.92 sec
2024-08-07T16:53:48.7411834Z       Start 23: RadiationStreamingY
2024-08-07T16:53:50.7126307Z 23/43 Test #23: RadiationStreamingY ...............   Passed    1.97 sec
2024-08-07T16:53:50.7126962Z       Start 24: SuOlsonTest
2024-08-07T16:54:00.1192519Z 24/43 Test #24: SuOlsonTest .......................   Passed    9.41 sec
2024-08-07T16:54:00.1193138Z       Start 25: RadiationPressureTube
2024-08-07T16:55:04.2777586Z 25/43 Test #25: RadiationPressureTube .............   Passed   64.16 sec
2024-08-07T16:55:04.2780823Z       Start 26: RadhydroShock
2024-08-07T16:55:23.4229329Z 26/43 Test #26: RadhydroShock .....................   Passed   19.14 sec
2024-08-07T16:55:23.4230103Z       Start 27: RadhydroShockCGS
2024-08-07T16:57:12.2981893Z 27/43 Test #27: RadhydroShockCGS ..................   Passed  108.87 sec
2024-08-07T16:57:12.2984231Z       Start 28: RadhydroShockMultigroup
2024-08-07T16:58:46.8131425Z 28/43 Test #28: RadhydroShockMultigroup ...........   Passed   94.51 sec
2024-08-07T16:58:46.8132536Z       Start 29: RadhydroUniformAdvecting
2024-08-07T16:58:49.6218101Z 29/43 Test #29: RadhydroUniformAdvecting ..........   Passed    2.81 sec
2024-08-07T16:58:49.6220237Z       Start 30: RadhydroPulseMGconst
2024-08-07T16:59:04.9842477Z 30/43 Test #30: RadhydroPulseMGconst ..............   Passed   15.36 sec
2024-08-07T16:59:04.9843105Z       Start 31: RadhydroPulseMGint
2024-08-07T16:59:23.8530084Z 31/43 Test #31: RadhydroPulseMGint ................   Passed   18.87 sec
2024-08-07T16:59:23.8530637Z       Start 32: RadhydroBB
2024-08-07T16:59:27.1578082Z 32/43 Test #32: RadhydroBB ........................   Passed    3.30 sec
2024-08-07T16:59:27.1578703Z       Start 33: BinaryOrbitCIC
2024-08-07T17:01:28.3685743Z 33/43 Test #33: BinaryOrbitCIC ....................   Passed  121.21 sec
2024-08-07T17:01:28.3695668Z       Start 34: FCQuantities
2024-08-07T17:01:30.3116805Z 34/43 Test #34: FCQuantities ......................   Passed    1.94 sec
2024-08-07T17:01:30.3117587Z       Start 35: ChannelFlow
2024-08-07T17:05:01.3831072Z 35/43 Test #35: ChannelFlow .......................   Passed  211.07 sec
2024-08-07T17:05:01.3849901Z       Start 36: ODEIntegration
2024-08-07T17:05:03.2961334Z 36/43 Test #36: ODEIntegration ....................   Passed    1.91 sec
2024-08-07T17:05:03.2964079Z       Start 37: PassiveScalar
2024-08-07T17:05:55.7032098Z 37/43 Test #37: PassiveScalar .....................   Passed   52.41 sec
2024-08-07T17:05:55.7035028Z       Start 38: PrimordialChem
2024-08-07T17:05:57.6740388Z 38/43 Test #38: PrimordialChem ....................   Passed    1.97 sec
2024-08-07T17:05:57.6742495Z       Start 39: ComputePerturbations
2024-08-07T17:05:58.7597802Z 39/43 Test #39: ComputePerturbations ..............   Passed    1.09 sec
2024-08-07T17:05:58.7598498Z       Start 40: PopIII
2024-08-07T17:06:02.3385450Z 40/43 Test #40: PopIII ............................   Passed    3.58 sec
2024-08-07T17:06:02.3386021Z       Start 41: ComputeStarClusterPerturbations
2024-08-07T17:06:05.9332641Z 41/43 Test #41: ComputeStarClusterPerturbations ...   Passed    3.59 sec
2024-08-07T17:06:05.9333297Z       Start 42: StarCluster
2024-08-07T17:06:44.8463303Z 42/43 Test #42: StarCluster .......................   Passed   38.91 sec
2024-08-07T17:06:44.8466672Z       Start 43: SphericalCollapse
2024-08-07T17:12:59.3488713Z 43/43 Test #43: SphericalCollapse .................   Passed  374.50 sec
2024-08-07T17:12:59.3495966Z 
2024-08-07T17:12:59.3496187Z 100% tests passed, 0 tests failed out of 43
2024-08-07T17:12:59.3498150Z 
2024-08-07T17:12:59.3498532Z Total Test time (real) = 2657.69 sec

@BenWibking BenWibking added this pull request to the merge queue Aug 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@BenWibking BenWibking mentioned this pull request Aug 7, 2024
Merged
7 tasks
Merged via the queue into development with commit d68f360 Aug 8, 2024
21 checks passed
@BenWibking BenWibking deleted the BenWibking/cuda-12-6-hotfix branch December 12, 2024 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@markkrumholz markkrumholz markkrumholz approved these changes

@chongchonghe chongchonghe Awaiting requested review from chongchonghe

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWibking @markkrumholz