Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Dockerfile #741

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Update Dockerfile #741

merged 5 commits into from
Sep 19, 2024

Conversation

BenWibking
Copy link
Collaborator

Description

This removes Sphinx dependencies from the included Dockerfile, since we no longer use Sphinx. ADIOS2 is also added to the Dockerfile (needed for OpenPMD I/O support).

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 17, 2024
Copy link

@chongchonghe
Copy link
Contributor

I would prefer clangd to be installed in the ubuntu container. Otherwise, everything looks good to me. @BenWibking

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
@BenWibking BenWibking added this pull request to the merge queue Sep 19, 2024
Merged via the queue into development with commit 5e5176c Sep 19, 2024
20 checks passed
@BenWibking BenWibking deleted the BenWibking/update-dockerfile branch December 12, 2024 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants