Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Restructure: put radiation flux update into a function #750

Merged
merged 20 commits into from
Sep 26, 2024

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented Sep 25, 2024

Description

This PR wraps the radiation flux update in source_terms_multi_group.hpp into a single function UpdateFlux. A new struct FluxUpdateResult is created to store the results from UpdateFlux.

Related issues

None.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 25, 2024
@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@chongchonghe
Copy link
Contributor Author

chongchonghe commented Sep 25, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. I had one question about the old scheme for the work term:

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@chongchonghe chongchonghe added this pull request to the merge queue Sep 26, 2024
Merged via the queue into development with commit aa2a618 Sep 26, 2024
22 checks passed
@chongchonghe chongchonghe deleted the chong/functions-for-flux branch September 26, 2024 06:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants