Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move enable_dust_gas_thermal_coupling_model to ISM_Traits #771

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

chongchonghe
Copy link
Contributor

@chongchonghe chongchonghe commented Oct 6, 2024

Description

Move the dust model switch enable_dust_gas_thermal_coupling_model from RadSystem_Traits to ISM_Traits so that the RadSystem_Traits is free of dust/non-LTE parameters.

Related issues

None.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 6, 2024
@chongchonghe
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@chongchonghe chongchonghe enabled auto-merge October 6, 2024 13:51
Copy link

sonarqubecloud bot commented Oct 7, 2024

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 7, 2024
@chongchonghe chongchonghe added this pull request to the merge queue Oct 7, 2024
Merged via the queue into development with commit 45cdad3 Oct 7, 2024
20 checks passed
@chongchonghe chongchonghe deleted the chong/move_dust_switch_to_ISM_traits branch October 7, 2024 10:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants