Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't warn for TF on Apple silicon #24

Merged
merged 1 commit into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

*Work-in-progress for QuPath v0.6.0*

* Compatibility with QuPath v0.6.0


## Version 0.3.0

Expand Down
7 changes: 3 additions & 4 deletions src/main/java/qupath/ext/djl/ui/DjlEngineCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -90,24 +90,23 @@ private enum EngineStatus {
/**
* Engine only supported on Linux
*/
private static Set<String> LINUX_ONLY = Set.of(
private static final Set<String> LINUX_ONLY = Set.of(
DjlTools.ENGINE_TENSORRT
);

/**
* Several engines definitely don't work on Apple Silicon (for now anyway).
*/
private static Set<String> UNSUPPORTED_APPLE_SILICON = Set.of(
private static final Set<String> UNSUPPORTED_APPLE_SILICON = Set.of(
DjlTools.ENGINE_PADDLEPADDLE,
DjlTools.ENGINE_TENSORFLOW,
DjlTools.ENGINE_TFLITE,
DjlTools.ENGINE_LIGHTGBM
);

/**
* Maintain a map to indicate if the engine is available or not
*/
private ObservableMap<String, ObjectProperty<EngineStatus>> available = FXCollections.observableHashMap();
private final ObservableMap<String, ObjectProperty<EngineStatus>> available = FXCollections.observableHashMap();

DjlEngineCommand(QuPathGUI qupath) {
this.qupath = qupath;
Expand Down
Loading