Set pipe year check >= 1800 instead > 1800 and add some verbosity in init_qwat.sh

[nicolas-sitylb]

• Set >= 1800 for pipe_year_check to accommodate the common usage of year 1800 for old pipes in survey offices..
  --> Resolve: Pipes with a year < 1801 raises a PostGIS error: violation of pipe_year_check constraint #367
• Add some verbosity in init_qwat.sh.
• Fix line return in insert_views.sh.
• Provide delta

[ponceta]

A delta is required with this code :

ALTER TABLE qwat_od.pipe DROP CONSTRAINT pipe_year_check ;

ALTER TABLE qwat_od.pipe ADD CONSTRAINT pipe_year_check CHECK (year IS NULL OR year >= 1800 AND (year <= EXTRACT(YEAR FROM NOW()) OR fk_status = 1306 AND year - 50 <= EXTRACT(YEAR FROM NOW())));

https://stackoverflow.com/questions/13244889/how-to-alter-constraint

[olivierdalang]

Hmm pum check should have failed without the delta, no ?

[ponceta]

To my knowledge, pum check the existence but not the syntax of constraints.

See :

https://github.com/opengisch/pum/blob/master/pum/core/checker.py#L178

[olivierdalang]

Ok, opened an issue here : opengisch/pum#103

IMO worth looking into as there may be inconsistencies in constraints btw the datamodel and an upgraded datamodel, which could be serious in terms of data integrity