Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Base Pagination #151

Merged
merged 15 commits into from
Feb 24, 2023
Merged

Base Pagination #151

merged 15 commits into from
Feb 24, 2023

Conversation

yishayhaz
Copy link
Contributor

@yishayhaz yishayhaz commented Feb 13, 2023 •
edited
Loading

What is it?

  • Feature/enhancement
  • Bug
  • Docs/tests

Description

Created a base pagination component
fully functional component for pagination

In the future, I will make it look better, add functionality, etc.

#130 - Add Pagination Component, no dependencies were affected

Screenshots/Demo

image

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix/functionality

yishayhaz and others added 3 commits February 13, 2023 23:15
@yishayhaz
feat(component & doc page): base pagination component
b9cc6e9 
base pagination component, it's fully working now, but it's not finished yet, I will add more
funcionallity & better design & code refactoring

Add Pagination component #130
@yishayhaz
Merge pull request #1 from yishayhaz/pagination
b035a2b 
feat(component & doc page): base pagination component
@yishayhaz
Signed CLA
98b989c
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yishayhaz
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 14, 2023
@github-actions
@yishayhaz has signed the CLA from Pull Request #151
4bf348b
gioboa
gioboa reviewed Feb 15, 2023
View reviewed changes
CLA.md Outdated Show resolved Hide resolved
gioboa
gioboa reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, it's good, there are only few things to change 🚀
I don't have strong opinion about the state, should stay inside or in the parent component (like in this implementation)

packages/headless/src/components/pagination/base.tsx Outdated Show resolved Hide resolved
packages/headless/src/components/pagination/base.tsx Outdated Show resolved Hide resolved
packages/website/src/routes/docs/daisy/pagination/index.tsx Show resolved Hide resolved
packages/website/src/routes/docs/headless/pagination/index.tsx Outdated Show resolved Hide resolved
@yishayhaz
refactor(pagination): no shared code
4c493cc 
instead of implementing the code twice, wrap the headless in the daisy (not finished yet)
@yishayhaz
Merge branch 'main' of https://github.com/qwikifiers/qwik-ui
805fa32
@yishayhaz
refactor(merged): merged
bf8745c
@yishayhaz
feat(pagination): pagination
0f292ec 
added a pagination for headless & daisy, changed approach & better ts

130
@yishayhaz
fix(merge): merge
a728b50
@yishayhaz
Copy link
Contributor Author

A different approach now.

HeadlessPagination Receives two additional props: 'RenderItem' and 'RenderDivider'.
DaisyPagination wraps HeadlessPagination, and passes RenderItem as DaisyButton

@yishayhaz
Copy link
Contributor Author

Must Add:

Support for RTL in arrow button & option to customize arrow buttons icons
currently the pagination is divided into 3 parts, the arrows, spacers, and 3 numbers in the middle. this number should be allowed to customize by a prop ''siblingCount" (mui for reference)

@gioboa
Copy link
Contributor

gioboa commented Feb 24, 2023

@all-contributors please add @yishayhaz for code

@allcontributors allcontributors bot mentioned this pull request Feb 24, 2023
Merged
@allcontributors
Copy link
Contributor

@gioboa

I've put up a pull request to add @yishayhaz! 🎉

@gioboa gioboa merged commit 76aed0e into qwikifiers:main Feb 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@gioboa gioboa gioboa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yishayhaz @gioboa