Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check() should use rcmdcheck() #1153

Closed
imanuelcostigan opened this issue Apr 16, 2016 · 7 comments
Closed

check() should use rcmdcheck() #1153

imanuelcostigan opened this issue Apr 16, 2016 · 7 comments
Labels
feature a feature request or enhancement has-pr

Comments

@imanuelcostigan
Copy link
Contributor

imanuelcostigan commented Apr 16, 2016

The latter has much better log formatting than the default R log.

rcmdcheck repo here

@hadley hadley added this to the 1.12.0 milestone Jun 2, 2016
@hadley
Copy link
Member

hadley commented Jun 2, 2016

Not on CRAN yet

@hadley hadley removed this from the 1.12.0 milestone Jun 2, 2016
@jimhester
Copy link
Member

Looks like it is actually https://cran.r-project.org/package=rcmdcheck

@hadley
Copy link
Member

hadley commented Jun 2, 2016

Ooops, I was looking for "rmdcheck"

@hadley
Copy link
Member

hadley commented Jun 2, 2016

Looking at a bit more, I don't think we can switch now because we have so much custom logic about envvars etc. Switching engines would be a lot of work

@jimhester
Copy link
Member

Probably true, I guess this can stay on the backlog until we can get to it.

@imanuelcostigan
Copy link
Contributor Author

is it bad form to 👍 ones own issue? Too late...

@hadley hadley added feature a feature request or enhancement rcmd and removed rcmd labels Nov 3, 2016
jimhester added a commit to jimhester/devtools that referenced this issue Aug 1, 2017
jimhester added a commit to jimhester/devtools that referenced this issue Aug 1, 2017
@hadley hadley added has-pr and removed check labels Aug 2, 2017
jimhester added a commit to jimhester/devtools that referenced this issue Aug 15, 2017
@lock
Copy link

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
feature a feature request or enhancement has-pr
Projects
None yet
Development

No branches or pull requests

3 participants