Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Forwarding arguments to rhub::check() from check_rhub() #2041

Closed
gaborcsardi opened this issue May 17, 2019 · 6 comments
Closed

Forwarding arguments to rhub::check() from check_rhub() #2041

gaborcsardi opened this issue May 17, 2019 · 6 comments

Comments

@gaborcsardi
Copy link
Member

Would be nice. ... is forwarded to build() currently. So maybe we can have a new rhub_check_args argument.

Alterrnatively, it could just print or document that people should use rhub::check() for more flexibility.

@gaborcsardi gaborcsardi changed the title Forwarding arguments to check_rhub Forwarding arguments to rhub::check() from check_rhub() May 17, 2019
@jimhester
Copy link
Member

We have build_args in devtools::check() so we should probably do the same in devtools::check_rhub() and then forward ... to rhub::check().

@gaborcsardi
Copy link
Member Author

Yeah, I think that would be best. A breaking change though, but people usually use rhub_check() interactively, I guess.

@maelle
Copy link
Contributor

maelle commented May 21, 2019

I'd be happy to make a PR, should I?

@gaborcsardi
Copy link
Member Author

@maelle yes, please!

@jimhester
Copy link
Member

Fixed by 75c8c23

@lock
Copy link

lock bot commented Dec 28, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 28, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants