Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Forwarding arguments to rhub::check() from check_rhub() #2047

Merged
merged 2 commits into from
May 28, 2019
Merged

Forwarding arguments to rhub::check() from check_rhub() #2047

merged 2 commits into from
May 28, 2019

Conversation

maelle
Copy link
Contributor

@maelle maelle commented May 21, 2019

cf #2041

@jimhester
Copy link
Member

Thanks! Can you please add (@yourname, #issuenumber) to the issue as well, you should get credit for it!

@maelle
Copy link
Contributor Author

maelle commented May 28, 2019

Done with credit to Gábor too 😉

@jimhester jimhester merged commit 7423626 into r-lib:master May 28, 2019
@jimhester
Copy link
Member

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @jimhester