Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test() errors on user-supplied stop_on_failure #2129

Closed
infotroph opened this issue Oct 1, 2019 · 1 comment
Closed

test() errors on user-supplied stop_on_failure #2129

infotroph opened this issue Oct 1, 2019 · 1 comment

Comments

@infotroph
Copy link
Contributor

> devtools::test(".", stop_on_failure=TRUE)
Loading [...]
Testing [...]
Error in (function (path, filter = NULL, reporter = default_reporter(),  : 
  formal argument "stop_on_failure" matched by multiple actual arguments

Looks like this arose in #2099.

Proposed fix: check for stop_on_failure in ... and then set if not found? E.g. change current line 61 to something like

testthat_args <- list(test_path, filter = filter, env = env,  ... = ...)
testthat_args$stop_on_failure <- testthat_args$stop_on_failure %||% FALSE
@lock
Copy link

lock bot commented Apr 2, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant