Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not load test helper with run_examples() #2560

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Do not load test helper with run_examples() #2560

merged 1 commit into from
Feb 16, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 16, 2024

Fixes #2559 because you do not need testthat helper when running examples!

@olivroy olivroy changed the title Update run-examples.R Do not load helper with run_examples() Feb 16, 2024
@olivroy olivroy changed the title Do not load helper with run_examples() Do not load test helper with run_examples() Feb 16, 2024
@jennybc
Copy link
Member

jennybc commented Feb 16, 2024

Seems reasonable. Thanks!

@jennybc jennybc merged commit c3fa3df into r-lib:main Feb 16, 2024
13 checks passed
@olivroy olivroy deleted the patch-1 branch February 19, 2024 13:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_examples() fails if tests/testthat/helper.R contains an un-exported function
2 participants