Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check() now checks pkgdown #2561

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

check() now checks pkgdown #2561

wants to merge 4 commits into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 20, 2024

fix #2449

If the pkgdown config is not okay, then it errors, should it just warn?

If we decide to keep on going, we could use

tryCatch(
  pkgdown::check_pkgdown(),
  error = function(cnd) {
    warning(conditionMessage(cnd), call. = FALSE)
  }
)

Maybe this should be pkgdown_sitrep() after pkgdown 2.1 to avoid tryCatch.

Perhaps this should happen as part of document in the build pane.
If roxygenize emited some type of output about what it did r-lib/roxygen2# would help that

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should devtools::check() also run pkgdown::check_pkgdown()?
1 participant