Skip to content

Simplify looks_different() #247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Simplify looks_different() #247

merged 1 commit into from
Jun 17, 2025

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 16, 2025

No description provided.

@hadley hadley requested a review from cderv June 16, 2025 18:50
@cderv cderv mentioned this pull request Jun 17, 2025
Draft
cderv

This comment was marked as duplicate.

# to view

cderv
cderv approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is valid change and easier to understand as %is_prefix_of% is covering all other checks

It still does not fix the problem are identical display list will be filtered out

@hadley hadley merged commit c744a58 into main Jun 17, 2025
14 checks passed
@hadley hadley deleted the looks-different branch June 17, 2025 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @cderv