Use brio::read_file() #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a decent speed increase.
|
I am afraid that it'll fail on Windows, no? But if this is really that slow, there should be another way to speed it up. |
|
Why would it fail? I've left the existing line ending conversion intact. |
|
Because brio forces UTF-8. Wasn't that the issue in roxygen2? I am not sure, but we'll see anyway. |
|
The CI was failing already before, so that does not mean much. I'll take a look at it on Windows. |
|
Anyway, I started on this because I though it might fix my invalid utf-8 character issue, but it only really delays the issue. So it's also fine to just close this. |
This was referenced Aug 13, 2021
|
I'll close this, because the check output is in the native encoding, so we cannot use brio here. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a decent speed increase.