use libpath arg during build

NAMESPACE

@@ -43,4 +43,5 @@ importFrom(utils,tail)
 importFrom(withr,local_path)
 importFrom(withr,with_dir)
 importFrom(withr,with_envvar)
+importFrom(withr,with_libpaths)
 importFrom(xopen,xopen)

NEWS.md

@@ -3,6 +3,8 @@
 
 * Update pkgdown template and move url to https://rcmdcheck.r-lib.org.
 
+* Fix usage of `libpath` argument (#195).
+
 # rcmdcheck 1.4.0
 
 * `cran_check_results()` now downloads results in parallel, so it is
@@ -34,7 +36,7 @@
   `rcmdcheck.test_output` global option, to control whether to print the full
   test output or not. (#121)
 
-* RStudio's Pandoc is now on the path during `rcmdcheck()` 
+* RStudio's Pandoc is now on the path during `rcmdcheck()`
   and `rcmdcheck_process` (#109, #132, @dpprdan).
 
 * `rcmdcheck()` now errors if the check process crashes (#110, #163).

R/build.R

@@ -1,6 +1,6 @@
 
 #' @importFrom pkgbuild pkgbuild_process
-#' @importFrom withr with_envvar
+#' @importFrom withr with_libpaths
 
 build_package <- function(path, tmpdir, build_args, libpath, quiet) {
   path <- normalizePath(path)
@@ -16,8 +16,8 @@ build_package <- function(path, tmpdir, build_args, libpath, quiet) {
     desc <- desc(path)
     clean_doc <- as_flag(desc$get("Config/build/clean-inst-doc"), NULL)
 
-    with_envvar(
-      c("R_LIBS_USER" = paste(libpath, collapse = .Platform$path.sep)), {
+    with_libpaths(
+      libpath, {
         proc <- pkgbuild_process$new(
           path,
           tmpdir,

tests/testthat/dependent_pkgs/pkg1/DESCRIPTION

@@ -0,0 +1,10 @@
+Package: pkg1
+Title: What the Package Does (One Line, Title Case)
+Version: 0.0.0.9000
+Authors@R:
+    person("First", "Last", , "first.last@example.com", role = c("aut", "cre"),
+           comment = c(ORCID = "YOUR-ORCID-ID"))
+Description: What the package does (one paragraph).
+Encoding: UTF-8
+Roxygen: list(markdown = TRUE)
+RoxygenNote: 7.2.3

tests/testthat/dependent_pkgs/pkg1/NAMESPACE

@@ -0,0 +1,3 @@
+# Generated by roxygen2: do not edit by hand
+
+export(foo1)

tests/testthat/dependent_pkgs/pkg1/R/foo1.R

@@ -0,0 +1,5 @@
+#' foo1 description
+#'
+#' foo1
+#' @export
+foo1 <- function() {1}

tests/testthat/dependent_pkgs/pkg2/DESCRIPTION

@@ -0,0 +1,16 @@
+Package: pkg2
+Title: What the Package Does (One Line, Title Case)
+Version: 0.0.0.9000
+Authors@R:
+    person("First", "Last", , "first.last@example.com", role = c("aut", "cre"),
+           comment = c(ORCID = "YOUR-ORCID-ID"))
+Description: What the package does (one paragraph).
+Imports:
+    pkg1
+Encoding: UTF-8
+Roxygen: list(markdown = TRUE)
+RoxygenNote: 7.2.3
+Suggests:
+    knitr,
+    rmarkdown
+VignetteBuilder: knitr

tests/testthat/dependent_pkgs/pkg2/NAMESPACE

@@ -0,0 +1,4 @@
+# Generated by roxygen2: do not edit by hand
+
+export(foo2)
+import(pkg1)

tests/testthat/dependent_pkgs/pkg2/R/foo2.R

@@ -0,0 +1,6 @@
+#' foo2 description
+#'
+#' foo2
+#' @import pkg1
+#' @export
+foo2 <- function() {2}

tests/testthat/dependent_pkgs/pkg2/vignettes/test.Rmd

@@ -0,0 +1,19 @@
+---
+title: "test"
+output: rmarkdown::html_vignette
+vignette: >
+  %\VignetteIndexEntry{test}
+  %\VignetteEngine{knitr::rmarkdown}
+  %\VignetteEncoding{UTF-8}
+---
+
+```{r, include = FALSE}
+knitr::opts_chunk$set(
+  collapse = TRUE,
+  comment = "#>"
+)
+```
+
+```{r setup}
+library(pkg2)
+```

tests/testthat/test-build.R

@@ -44,3 +44,21 @@ test_that("inst/doc can be kept", {
   pkg <- build_package(bad3, tempfile(), character(), .libPaths(), TRUE)
   expect_true(file.exists(rubbish))
 })
+
+test_that("libpath argument is used in build_package", {
+  lib <- tempfile()
+  on.exit(unlink(lib, recursive = TRUE), add = TRUE)
+  dir.create(lib)
+
+  pkg1_source <- test_path("dependent_pkgs", "pkg1")
+  pkg1 <- pkgbuild::build(pkg1_source, quiet = TRUE)
+  on.exit(unlink(pkg1, recursive = TRUE), add = TRUE)
+  install.packages(pkg1, lib = lib, repos = NULL, type = "source", quiet = TRUE)
+
+  pkg2_source <- test_path("dependent_pkgs", "pkg2")
+  expect_error({
+    build_package(pkg2_source, tempfile(), character(), .libPaths(), TRUE)
+  })
+  pkg2 <- build_package(pkg2_source, tempfile(), character(), c(lib, .libPaths()), TRUE)
+  expect_true(file.exists(pkg2))
+})