Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(parse_as_gha_url): job URL changed from jobs/ to job/ #103

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gadenbuie
Copy link
Contributor

Fixes #89

parse_as_gha_url("https://github.com/r-lib/sessioninfo/actions/runs/10251844492/job/28360805716")
#>   owner        repo      run_id     html_id
#> 1 r-lib sessioninfo 10251844492 28360805716

GHA updated the URL structure replacing jobs/ with job/ in the URL. I updated the regular expression to make the trailing s optional. After this fix, the following use of session_diff() should work again.

sessioninfo::session_diff(new = "https://github.com/r-lib/sessioninfo/actions/runs/10251844492/job/28360805716")

@gaborcsardi
Copy link
Member

Great, thanks a lot!

@gaborcsardi gaborcsardi merged commit f42531b into r-lib:main Aug 28, 2024
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session_diff() is broken again for GHA URLs
2 participants