More tweaks re: extracting session info from GHA logs #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been sessiondiff'ing GHA logs again, which lead to the discovery that something about line breaks has changed. Unclear if that's on the GitHub end (probably) or us (less likely). That's why I want to split on
\r\nor\n.Then I also experienced what happens to these URLs when you re-run a failing job: the current strategy to get the log fails for the original URL (corresponding to not-the-most-recent attempt). That could be fixed because clearly there's a way to get logs from attempts other than the latest, but I don't think it's worth it. But we can at least throw a semi-decent error.