Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix new lints about implicit return #1166

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b70d75c) 92.16% compared to head (143f027) 92.16%.

❗ Current head 143f027 differs from pull request most recent head ee2b7c8. Consider uploading reports for the commit ee2b7c8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1166   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          46       46           
  Lines        2655     2655           
=======================================
  Hits         2447     2447           
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b70d75c is merged into main:

  •   :ballot_box_with_check:cache_applying: 165ms -> 174ms [-2.44%, +13.22%]
  •   :ballot_box_with_check:cache_recording: 562ms -> 550ms [-4.75%, +0.55%]
  •   :ballot_box_with_check:without_cache: 1.04s -> 1.04s [-1.2%, +1.27%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this refactoring.

@lorenzwalthert lorenzwalthert merged commit cb33e89 into main Dec 5, 2023
18 checks passed
@IndrajeetPatil IndrajeetPatil deleted the fix-return-lints branch December 5, 2023 07:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants