Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add non-US locale and use pak to upgrade packages in GHA #1200

Merged
merged 10 commits into from
May 9, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

To check #1199

@lorenzwalthert
Copy link
Collaborator

Still wanna merge this or not necessary anymore?

@IndrajeetPatil
Copy link
Collaborator Author

Still wanna merge this or not necessary anymore?

Yes, this will be still helpful to us in the long term.


env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes

steps:
- name: Set locale
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have just one step for setting the locale and reference the value from the matrix as an env variable? If not directly, turn the context into a env variable first and then access it? Like this?

      - name: Set locale
        env:
          OVERRIDE_LOCALE: '${{ matrix.config.locale }}'
        run: echo $OVERRIDE_LOCALE >> $GITHUB_ENV

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solutions to DRYing this up was leading to more complicate code, so I am going to retain the more readable individual steps for now.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (1a3ef50) to head (15cf8f5).
Report is 7 commits behind head on main.

❗ Current head 15cf8f5 differs from pull request most recent head 83de14c. Consider uploading reports for the commit 83de14c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files          46       46           
  Lines        2657     2657           
=======================================
  Hits         2449     2449           
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil changed the title Get builds to run on win-devel Add non-US locale and use pak to upgrade packages in GHA May 9, 2024
@IndrajeetPatil IndrajeetPatil merged commit 99afa8d into main May 9, 2024
15 checks passed
@IndrajeetPatil IndrajeetPatil deleted the check-win-devel-stringi-install branch May 9, 2024 08:53
IndrajeetPatil added a commit that referenced this pull request May 11, 2024
regression introduced in #1200
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants