-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add non-US locale and use pak to upgrade packages in GHA #1200
Conversation
Still wanna merge this or not necessary anymore? |
Yes, this will be still helpful to us in the long term. |
.github/workflows/check-full.yaml
Outdated
|
||
env: | ||
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
R_KEEP_PKG_SOURCE: yes | ||
|
||
steps: | ||
- name: Set locale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have just one step for setting the locale and reference the value from the matrix as an env variable? If not directly, turn the context into a env variable first and then access it? Like this?
- name: Set locale
env:
OVERRIDE_LOCALE: '${{ matrix.config.locale }}'
run: echo $OVERRIDE_LOCALE >> $GITHUB_ENV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solutions to DRYing this up was leading to more complicate code, so I am going to retain the more readable individual steps for now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 46 46
Lines 2657 2657
=======================================
Hits 2449 2449
Misses 208 208 ☔ View full report in Codecov by Sentry. |
regression introduced in #1200
To check #1199