Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check for warnings in examples and tests #1219

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

@lorenzwalthert We can either do this and/or add a new workflow from lintr that runs tests in strict mode.

I prefer doing both, but wanted to first check with you.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (4665f2d) to head (173d397).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   91.57%   91.60%   +0.02%     
==========================================
  Files          46       46              
  Lines        2647     2656       +9     
==========================================
+ Hits         2424     2433       +9     
  Misses        223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzwalthert
Copy link
Collaborator

I also prefer both 👍.

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Jul 1, 2024

Do we really need a separate workflow or can we incorporate it an existing one? I try to limit compute time.

@IndrajeetPatil
Copy link
Collaborator Author

Do we really need a separate workflow or can we incorporate it an existing one? I try to limit compute time.

Not really. I have consolidated two workflows into one to check for warnings in both examples and tests.

@IndrajeetPatil IndrajeetPatil changed the title Check for warnings in examples Check for warnings in examples and tests Nov 30, 2024
Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IndrajeetPatil.

@IndrajeetPatil IndrajeetPatil merged commit 94225ae into main Nov 30, 2024
17 checks passed
@IndrajeetPatil IndrajeetPatil deleted the strict-examples branch November 30, 2024 22:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants