-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Check for warnings in examples and tests #1219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
+ Coverage 91.57% 91.60% +0.02%
==========================================
Files 46 46
Lines 2647 2656 +9
==========================================
+ Hits 2424 2433 +9
Misses 223 223 ☔ View full report in Codecov by Sentry. |
I also prefer both 👍. |
Do we really need a separate workflow or can we incorporate it an existing one? I try to limit compute time. |
Not really. I have consolidated two workflows into one to check for warnings in both examples and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IndrajeetPatil.
@lorenzwalthert We can either do this and/or add a new workflow from lintr that runs tests in strict mode.
I prefer doing both, but wanted to first check with you.