Re-normalize path, after it is guaranteed to exist (#228)

* Add failing test

* Re-normalize path, after it is guaranteed to exist

Fixes #227

* Extend fix and test to non-package project case

* NEWS bullet

NEWS.md

@@ -1,5 +1,7 @@
 # usethis 1.2.0.9000
 
+* `create_package()` and `create_project()` return a normalized path, even if target directory does not pre-exist (#227, #228).
+
 # usethis 1.2.0
 
 ## New functions

R/create.R

@@ -26,6 +26,9 @@ create_package <- function(path,
 
   create_directory(dirname(path), name)
   cat_line(crayon::bold("Changing active project to", crayon::red(name)))
+  ## the initial normalizePath() may not have returned an absolute path,
+  ## if the path did not yet exist
+  path <- normalizePath(path, mustWork = TRUE)
   proj_set(path, force = TRUE)
 
   use_directory("R")
@@ -55,6 +58,9 @@ create_project <- function(path,
 
   create_directory(dirname(path), name)
   cat_line(crayon::bold("Changing active project to", crayon::red(name)))
+  ## the initial normalizePath() may not have returned an absolute path,
+  ## if the path did not yet exist
+  path <- normalizePath(path, mustWork = TRUE)
   proj_set(path, force = TRUE)
 
   use_directory("R")

tests/testthat/test-create.R

@@ -22,3 +22,29 @@ test_that("nested project is disallowed, by default", {
   subdir <- create_directory(dir, "subdir")
   expect_error(scoped_temporary_project(subdir), "nested")
 })
+
+## https://github.com/r-lib/usethis/issues/227
+test_that("proj is normalized when path does not pre-exist", {
+  ## take care to provide a **non-absolute** path
+  path_package <- basename(tempfile())
+  withr::with_dir(
+    tempdir(), {
+      old_proj <- proj_get()
+      capture_output(create_package(path_package, rstudio = FALSE, open = FALSE))
+      new_proj <- proj_get()
+      proj_set(old_proj)
+    }
+  )
+  expect_true(dir.exists(new_proj))
+
+  path_project <- basename(tempfile())
+  withr::with_dir(
+    tempdir(), {
+      old_proj <- proj_get()
+      capture_output(create_project(path_project, rstudio = FALSE, open = FALSE))
+      new_proj <- proj_get()
+      proj_set(old_proj)
+    }
+  )
+  expect_true(dir.exists(new_proj))
+})