Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Return the correct urls from appveyor #240

Merged
merged 3 commits into from
Feb 12, 2018
Merged

Return the correct urls from appveyor #240

merged 3 commits into from
Feb 12, 2018

Conversation

llrs
Copy link
Contributor

@llrs llrs commented Feb 11, 2018

Previously the appveyor badge was not properly rendered as appveyor_info returned the url of the repository as the image. The change only affects the name of the urls returned by appveyor_info to be used by use_badge_appveyor.

Previously the appveyor badge was not properly rendered as it returned the url of the repository as the image.
@jennybc
Copy link
Member

jennybc commented Feb 12, 2018

Thanks!

I tested this locally and found another pre-existing problem. Want to fix it too while you're making this PR? Please make the url assignment look like this:

  url <- file.path(
    "https://ci.appveyor.com",
    "project",
    gh$username,
    gh$repo
  )

The "project" part needs to be added.

Also go ahead and add a NEWS bullet about this fix.

@llrs
Copy link
Contributor Author

llrs commented Feb 12, 2018

I'm not sure if I should increment the package version, let me know which version scheme do you want, or if I should move the bullet under the 1.2.0.9000 version comments.

@jennybc
Copy link
Member

jennybc commented Feb 12, 2018

I'll merge and tweak the NEWS myself and tag you, so you see our style for future. I've made a note that we should clarify this in our contributing template. Which, ironically, this repo is not using itself! Will fix that too.

Thanks.

@jennybc jennybc merged commit f6fd935 into r-lib:master Feb 12, 2018
@llrs
Copy link
Contributor Author

llrs commented Feb 13, 2018

Yes, I looked for it but I couldn't find any contributing template (or code of conduct for what it matters).
Glad to help.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants