Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move proj_path to a more appropriate place in use_addin #619

Merged
merged 9 commits into from
Mar 6, 2019
Merged

Move proj_path to a more appropriate place in use_addin #619

merged 9 commits into from
Mar 6, 2019

Conversation

haozhu233
Copy link
Contributor

@haozhu233 haozhu233 commented Feb 4, 2019 •
edited by jennybc
Loading

As Jenny suggested in #591 (comment), it was odd to only use proj_path at the very end. In this PR, I moved proj_path to the top of the script.

@jennybc
Copy link
Member

jennybc commented Mar 6, 2019

Thanks!

@jennybc jennybc merged commit a39e54b into r-lib:master Mar 6, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haozhu233 @jennybc @hadley