-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create a way to configure git protocol and git2r credentials #653
Conversation
It's github_this() vs. gh_this(). It's an auth_token, not a pat.
@cderv @ijlyttle With this merged, I think we are going to have much more success with HTTPS and on Windows, because I make a git2r credential from the GitHub PAT whenever possible. Now I will use this to wire this all in to the PR flow. But starting now, it would be great for you two to test drive this as much as possible. It's nearly impossible to test. I do some manual tests but I don't cover many scenarios. |
First try with a ˋpr_fetch` and first error. Something does not work as intended with git2r::fetch and credentials. |
So far, I have succeeded, no problems, on macOS with: I'll use more of the functions today and try things with Windows. |
ok my bad, this is working now with last pr updates. Will continue to test and open specific issues if needed. |
Gives us:
git_protocol()
/use_git_protocol()
to summon or set a default protocol (so, either SSH or HTTPS)git2r_credentials()
/use_git2r_credentials()
to summon or set git2r credentialsThis addresses your earlier distaste @hadley for getting and setting
protocol
with the same function, i.e. I've split it out and followed same design forcredentials
.Clears the way for me to tackle #533 Build protocol flexibility into
pr_*()
functions