Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pr_pause just switches back to master if no remote branch #715

Merged
merged 5 commits into from
Jun 4, 2019

Conversation

cderv
Copy link
Contributor

@cderv cderv commented Apr 14, 2019

Fixes #714

Small fix as you can see. I just return early if no remote.

One think I am not sure: Should there be a message or no message as there is no remote to check ?

> pr_pause()
✔ No remote branch yet for local branch 'fix-714-pause-no-remote'.Switching back to 'master' branch

or

> pr_pause()
✔ Switching back to 'master' branch

@cderv cderv changed the title pr_pause just switch back to master if no remote branch pr_pause just switches back to master if no remote branch Apr 14, 2019
@jennybc
Copy link
Member

jennybc commented Jun 4, 2019

Thanks!

@jennybc jennybc merged commit 2baa06f into r-lib:master Jun 4, 2019
@cderv cderv deleted the fix-714-pause-no-remote branch June 4, 2019 21:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pr_pause throw error if branch not already pushed
2 participants