pr_push() can now push to repo with no pr (#990) #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes r-lib#990 The is the minimal fix, maybe too terse. A more expressive solution comes in a separate commit, to allow reverting it if you prefer the shorter solution. The tests will also come in a separate commit because they test the internal `pr_find()` instead of the exported `pr_push()`. You may want to revert that upcomming commit too.
|
Thanks! I made some updates. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #990
4411390 tests an internal function and uses a test repo in my personal account. Instead you may want to test an exported function and use a repo that you control.