Skip to content

Commit

Permalink
Merge branch 'master' into devel
Browse files Browse the repository at this point in the history
Former-commit-id: 8b91670
  • Loading branch information
Jean-Romain committed Apr 11, 2018
2 parents 00402fb + 3fffbe1 commit 5b9e355
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 20 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
![CRAN](https://img.shields.io/badge/CRAN-1.1.9-brightgreen.svg) ![Github](https://img.shields.io/badge/Github-1.2.0-green.svg) ![licence](https://img.shields.io/badge/Licence-GPL--3-blue.svg)
![CRAN](https://img.shields.io/badge/CRAN-1.2.0-brightgreen.svg) ![Github](https://img.shields.io/badge/Github-1.2.0-green.svg) ![licence](https://img.shields.io/badge/Licence-GPL--3-blue.svg)

R package to read and write `.las` and `.laz` binary files used to store LiDAR data.

Expand Down
21 changes: 2 additions & 19 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@
This is an early release because compilation failed on CRAN with osx and solaris (segfault)

There was indeed a segfault in the code that, for an unknown reason, was not a segfault in any
other platform. I was not able to reproduce the issue whatever the compiler I used. The only
way I reproduced the segfault was compiling the package via the r-hub.io osx builder.

I fixed the bug and I added several extra tests. The bug is fully fixed on osx according to
osx builder on r-hub.io. However it does not compile for solaris on r-hub.io but the config
seems different than the one on the CRAN. Previous release compiled properly on solaris. So
I'm confident and I'm expecting that everything should go fine since the code did not change.

The package should be compiled on solaris and osx first to figure out if everything is good
on those two platforms.

## Test environments
* Linux Mint 18 (Ubuntu 16.04), R 3.4.3, g++ -std=gnu++11
* Linux Mint 18 (Ubuntu 16.04), R 3.4.3, g++-7 -std=gnu++11
* Linux Mint 18 (Ubuntu 16.04), R 3.4.3, clang++ -stdlib=libc++
* Linux Mint 18 (Ubuntu 16.04), R 3.4.3, clang++-4.0 -stdlib=libc++
* Linux Mint 18 (Ubuntu 16.04), R 3.4.3, clang++-4.0 -std-gnu++11
* Linux Mint 18 (Ubuntu 16.04), R 3.4.4, g++ -std=gnu++11
* Linux Mint 18 (Ubuntu 16.04), R 3.4.4, g++-7 -std=gnu++11
* osx release via r-hub.io builder
* windows via CRAN builder

Expand Down

0 comments on commit 5b9e355

Please # to comment.