Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: upgrade to stable2407 #45

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 23, 2024

Status: ✅ Compiled and built successfully

Direct changes

  • [#5011]: Use BadOrigin from sp_runtime
  • [#4097]: Introduce experimental slot-based collator
  • [#5040]: Update libp2p-websocket to v0.42.2

Copy link
Contributor

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every change that seems necessary is included 👍
Approving as the code works perfectly fine.

Only thing from my side would be that I would vote for rolling back the refactor on the constants naming. Not separating the prefixes, but separating only whole words :)

@AlexD10S AlexD10S self-requested a review August 28, 2024 09:10
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chungquantin chungquantin merged commit 4c8b132 into main Sep 18, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants