Use updated ghactions4r workflow in r4ss #982
Conversation
|
This branch had some attempts to work on another issue but those were reverted and all the commits will just be squashed when merged. |
There was a problem hiding this comment.
@e-perl-NOAA, thanks for working on this.
The changes look good (based on my rudimentary understanding of yml files), but it's still failing on the macOS-latest. Any idea why?
|
It's still failing because of the change to the get_ss3_exe() function to not use tokens in the gh::gh() call. With github actions, the same runner for mac is used so it calls the api enough times that the github api gets mad. I have no idea how to fix it for github actions. I tried several things but didn't get anywhere. See here for a more eloquent explanation of what is going on. |
|
The fix in #986 should have this PR work fine now, but it looks like we should change the |
|
Sorry @iantaylor-NOAA I didn't realize that I hadn't changed that back to main but that's why we have these reviews! |
|
It might still fail because it's using the github action from this branch, not the one from main. I would need to rebase this branch to get it passing all the checks which I can do if you would like. |
See issue #981.