Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make sf package optional #214

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Make sf package optional #214

merged 2 commits into from
Jun 18, 2021

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Jun 18, 2021

Fix to issue #213, effectively making get_eurostat_geospatial function produce an error:

Loading required namespace: sf
Failed with error:  ‘there is no package called ‘sf’’
'sf' package is required for geospatial functionalities

Package check produces 1 note when sf is not installed:

checking package dependencies ... NOTE
Package suggested but not available for checking: ‘sf’

The cleanest solution might be to put geospatial functionalities in a new package but maybe this PR is not the place for that discussion

@antagomir
Copy link
Member

Yes - separating geospatial functionalities has been discussed in the past as well, and could make sense. Let's keep up the planning!

@antagomir antagomir merged commit bd1ee93 into master Jun 18, 2021
@pitkant pitkant deleted the pitkant branch June 18, 2021 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants