Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce dependencies #232

Merged
merged 4 commits into from
Oct 2, 2021
Merged

Reduce dependencies #232

merged 4 commits into from
Oct 2, 2021

Conversation

dieghernan
Copy link
Member

@dieghernan dieghernan commented Oct 1, 2021

Some dependencies moved to pkgdown action.

Also, restart the cache to perform a full clean test

#230

@dieghernan
Copy link
Member Author

Now add_nuts_level uses regions::validate_nuts_regions and is compatible with released version of the function

@dieghernan dieghernan marked this pull request as ready for review October 1, 2021 17:08
@dieghernan
Copy link
Member Author

dieghernan commented Oct 1, 2021

This is ready. In the package side, only small changes on deprecated functions and the vignette,

@antagomir
Copy link
Member

Seems good to me at least.

@dieghernan
Copy link
Member Author

In the fresh installation (macOS) of the action I see now:

✔ 92 + 3 pkgs | kept 94, updated 1, new 0 | downloaded 1 (NA B) [23.5s]

vs the previous one:

✔ 143 + 3 pkgs | kept 145, updated 1, new 0 | downloaded 1 (NA B) [33.3s]

Although this may be a temporary fix
Copy link
Member

@pitkant pitkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@pitkant pitkant merged commit 6c56e12 into master Oct 2, 2021
@pitkant pitkant deleted the cleandeps branch October 2, 2021 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants