khepri_mnesia_migration.app: Do not depend on Mnesia or Khepri #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage 74.74% 74.74%
=======================================
Files 13 13
Lines 586 586
=======================================
Hits 438 438
Misses 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[Why] khepri_mnesia_migration obviously relies on Mnesia and Khepri to perform its task. However, we don't want to explicitly depend on them because in an Erlang release, this will cause Mnesia and Khepri to be started automatically by default. Given the context where this application is used, it possible the user does not want both to be running at all time. Therefore, we leave them alone. The user of khepri_mnesia_migration already depends on Mnesia and Khepri. Thus we let the user handle the dependency and the start of Mnesia and Khepri. [How] Mnesia and Khepri are removed from the `applications` entry in the app(4) file. We add `khepri` to the `plt_extra_apps` configuration parameter in `rebar.config` so that Dialyzer still knows about it.
dumbbell
force-pushed
the
remove-mnesia-and-khepri-as-deps-in-app-file
branch
from
8845da7 to
bb4f5ef
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
khepri_mnesia_migration obviously relies on Mnesia and Khepri to perform its task. However, we don't want to explicitly depend on them because in an Erlang release, this will cause Mnesia and Khepri to be started automatically by default.
Given the context where this application is used, it possible the user does not want both to be running at all time. Therefore, we leave them alone. The user of khepri_mnesia_migration already depends on Mnesia and Khepri. Thus we let the user handle the dependency and the start of Mnesia and Khepri.
How
Mnesia and Khepri are removed from the
applicationsentry in the app(4) file.We add
kheprito theplt_extra_appsconfiguration parameter inrebar.configso that Dialyzer still knows about it.