m2k_table_copy: Handle existing projection #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] Thanks to concurrency, it's possible that the projection is created between the attempt to use it and the call to `setup_projection/2`. If this happens, the setup fails with an error telling the projection already exists. This is not a fatal error, we should simply retry to read the projection's table. [How] We handle both the old and the new possible "projection already exists" error terms and retry the function if this occurs.
|
This is similar to what has been done in rabbitmq/rabbitmq-server#10868. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 75.49% 75.26% -0.23%
==========================================
Files 13 13
Lines 657 659 +2
==========================================
Hits 496 496
- Misses 161 163 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the-mikedavis
approved these changes
May 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Thanks to concurrency, it's possible that the projection is created between the attempt to use it and the call to
setup_projection/2. If this happens, the setup fails with an error telling the projection already exists.This is not a fatal error, we should simply retry to read the projection's table.
How
We handle both the old and the new possible "projection already exists" error terms and retry the function if this occurs.