mnesia_to_khepri: Speed is_migration_finished() up
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The current approach queries Khepri to determine if a migration is in progress or even finished. This is quite expensive for what is expected a quick check to decide between the Mnesia and Khepri functions. [How] We use a Khepri projection and an ETS table to cache the migration statuses. This way, the check simply becomes an ETS lookup.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
- Coverage 74.95% 74.01% -0.95%
==========================================
Files 13 13
Lines 599 608 +9
==========================================
+ Hits 449 450 +1
- Misses 150 158 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current approach queries Khepri to determine if a migration is in progress or even finished. This is quite expensive for what is expected a quick check to decide between the Mnesia and Khepri functions.
How
We use a Khepri projection and an ETS table to cache the migration statuses. This way, the check simply becomes an ETS lookup.