mnesia_to_khepri: Check record validity before calling Mod:copy_to_khepri/3
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 75.39% 75.49% +0.10%
==========================================
Files 13 13
Lines 634 657 +23
==========================================
+ Hits 478 496 +18
- Misses 156 161 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dumbbell
force-pushed
the
ignore-non-records-in-copy_to_khepri
branch
3 times, most recently
from
e6a7cdd to
6c8902a
Compare
…hepri/3` [Why] It appears that we get Mnesia write events with the table name and the key, instead of the table name and the written record. The expected event seems to come after. We can't do anything with just the key and we want to skip calls to the callback module in this case. [How] To distinguish the key from the expected record, we first query the table info to get the record name and its arity. Then, we verify the received term against the queried record definition to check if the term is a valid record before calling `Mod:copy_to_khepri/3`.
dumbbell
force-pushed
the
ignore-non-records-in-copy_to_khepri
branch
from
6c8902a to
4207644
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It appears that we get Mnesia write events with the table name and the key, instead of the table name and the written record. The expected event seems to come after.
We can't do anything with just the key and we want to skip calls to the callback module in this case.
How
To distinguish the key from the expected record, we first query the table info to get the record name and its arity. Then, we verify the received term against the queried record definition to check if the term is a valid record before calling
Mod:copy_to_khepri/3.