Merge pull request #9357 from rabbitmq/mergify/bp/v3.12.x/pr-9356

Improve consumer metric cleanup when a channel goes down (backport #9356)
rabbitmq · Sep 9, 2023 · ce08775 · ce08775
2 parents d53be96 + a5c9ca1
commit ce08775
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/deps/rabbit/src/rabbit_amqqueue_process.erl b/deps/rabbit/src/rabbit_amqqueue_process.erl
@@ -909,7 +909,7 @@ handle_ch_down(DownPid, State = #q{consumers                 = Consumers,
             {ok, State1};
         {ChAckTags, ChCTags, Consumers1} ->
             QName = qname(State1),
-            [emit_consumer_deleted(DownPid, CTag, QName, ?INTERNAL_USER) || CTag <- ChCTags],
+            [rabbit_core_metrics:consumer_deleted(DownPid, CTag, QName) || CTag <- ChCTags],
             Holder1 = new_single_active_consumer_after_channel_down(DownPid, Holder, SingleActiveConsumerOn, Consumers1),
             State2 = State1#q{consumers          = Consumers1,
                               active_consumer    = Holder1},

diff --git a/deps/rabbitmq_management_agent/src/rabbit_mgmt_metrics_gc.erl b/deps/rabbitmq_management_agent/src/rabbit_mgmt_metrics_gc.erl
@@ -136,6 +136,18 @@ delete_samples(Table, Id, Intervals) ->
     [ets:delete(Table, {Id, I}) || I <- Intervals],
     ok.
 
+index_delete(consumer_stats = Table, channel = Type, Id) ->
+    IndexTable = rabbit_mgmt_metrics_collector:index_table(Table, Type),
+    MatchPattern = {'_', Id, '_'},
+    %% Delete consumer_stats_queue_index
+    ets:match_delete(consumer_stats_queue_index,
+                     {'_', MatchPattern}),
+    %% Delete consumer_stats
+    ets:match_delete(consumer_stats,
+                     {MatchPattern,'_'}),
+    %% Delete consumer_stats_channel_index
+    ets:delete(IndexTable, Id),
+    ok;
 index_delete(Table, Type, Id) ->
     IndexTable = rabbit_mgmt_metrics_collector:index_table(Table, Type),
     Keys = ets:lookup(IndexTable, Id),